Patch for ABE on RHEL

Discussion:

Scott Telford

2016-10-14 10:38:14 UTC

Just been trying to build the Linaro toolchain from source on RHEL 6.5. The ABE configure script fails to detect the packaging system on RHEL as it looks like RPM will only be detected if it's running on a Fedora system. This patch will instead detect RPM if the rpm binary is available (and it's not Debian/Ubuntu), like the test for Arch/pacman.

diff --git a/configure b/configure
index 42f787e..52ddd42 100755
--- a/configure
+++ b/configure
@@ -3639,7 +3639,6 @@ fi

# Figure out which packaging system is in use. Since it's possible to
# install both on a system.
-rpm="`uname -a | grep -ic '\.fc[0-9].\.'`"
deb="`uname -a | grep -ic 'ubuntu'`"
deb=$(($deb + `uname -a | grep -ic 'debian'`))

@@ -3672,7 +3671,9 @@ $as_echo "yes" >&6; }

### RPM Packages ###
else
-if test ${rpm} -eq 1; then
+rpm="`which rpm 2> /dev/null`"
+result=$?
+if test ${result} -eq 0; then
packages="${packages} ncurses-devel python-devel"
for i in ${packages}; do
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking if $i is installed" >

Regards,
Scott.

Maxim Kuvyrkov

2016-10-14 10:54:36 UTC

Permalink

Thanks Scott!

I've uploaded a fixed version of your patch to https://review.linaro.org/14757. One needs to modify configure.ac and then re-generate configure by running autoconf.

Once the patch is approved it will be merged into abe.

--
Maxim Kuvyrkov
www.linaro.org

Post by Scott Telford
Just been trying to build the Linaro toolchain from source on RHEL 6.5. The ABE configure script fails to detect the packaging system on RHEL as it looks like RPM will only be detected if it's running on a Fedora system. This patch will instead detect RPM if the rpm binary is available (and it's not Debian/Ubuntu), like the test for Arch/pacman.
diff --git a/configure b/configure
index 42f787e..52ddd42 100755
--- a/configure
+++ b/configure
@@ -3639,7 +3639,6 @@ fi
# Figure out which packaging system is in use. Since it's possible to
# install both on a system.
-rpm="`uname -a | grep -ic '\.fc[0-9].\.'`"
deb="`uname -a | grep -ic 'ubuntu'`"
deb=$(($deb + `uname -a | grep -ic 'debian'`))
@@ -3672,7 +3671,9 @@ $as_echo "yes" >&6; }
### RPM Packages ###
else
-if test ${rpm} -eq 1; then
+rpm="`which rpm 2> /dev/null`"
+result=$?
+if test ${result} -eq 0; then
packages="${packages} ncurses-devel python-devel"
for i in ${packages}; do
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking if $i is installed" >
Regards,
Scott.
_______________________________________________
linaro-toolchain mailing list
https://lists.linaro.org/mailman/listinfo/linaro-toolchain

Maxim Kuvyrkov

2016-10-17 12:39:55 UTC

Permalink

Hi Scott,

Your patch has been merged into abe:master.

--
Maxim Kuvyrkov
www.linaro.org

Post by Maxim Kuvyrkov
Thanks Scott!
I've uploaded a fixed version of your patch to https://review.linaro.org/14757. One needs to modify configure.ac and then re-generate configure by running autoconf.
Once the patch is approved it will be merged into abe.
--
Maxim Kuvyrkov
www.linaro.org